-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-27468][Core][WEBUI] BlockUpdate replication event shouldn't overwrite storage level description in the UI #24398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -917,8 +917,24 @@ private[spark] class AppStatusListener( | |||||||||||
| // Update the block entry in the RDD info, keeping track of the deltas above so that we | ||||||||||||
| // can update the executor information too. | ||||||||||||
| liveRDDs.get(block.rddId).foreach { rdd => | ||||||||||||
|
|
||||||||||||
| if (updatedStorageLevel.isDefined) { | ||||||||||||
| rdd.setStorageLevel(updatedStorageLevel.get) | ||||||||||||
| // Replicated block update events will have `storageLevel.replication=1`. | ||||||||||||
| // To avoid overwriting the block replicated event in the store, we need to | ||||||||||||
| // have a check for whether the event is block replication or not. | ||||||||||||
| // Default value of `storageInfo.replication = 1` and hence if | ||||||||||||
| // `storeLevel.replication = 2`, the replicated events won't overwrite in the store. | ||||||||||||
| val storageInfo = rdd.storageInfo | ||||||||||||
| val isReplicatedBlockUpdateEvent = storageLevel.replication < storageInfo.replication && | ||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, This line checks the storageLevel is valid or not. spark/core/src/main/scala/org/apache/spark/status/AppStatusListener.scala Lines 916 to 920 in d9bcacf
updatedStorageLevel will be None. So, it won't come to this line (L-928).Thanks |
||||||||||||
| (storageInfo.useDisk == storageLevel.useDisk && | ||||||||||||
| storageInfo.useMemory == storageLevel.useMemory && | ||||||||||||
| storageInfo.deserialized == storageLevel.deserialized && | ||||||||||||
| storageInfo.useOffHeap == storageLevel.useOffHeap) | ||||||||||||
|
|
||||||||||||
| if (!isReplicatedBlockUpdateEvent) { | ||||||||||||
| rdd.storageInfo = storageLevel | ||||||||||||
|
srowen marked this conversation as resolved.
Outdated
|
||||||||||||
| rdd.setStorageLevel(updatedStorageLevel.get) | ||||||||||||
| } | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| val partition = rdd.partition(block.name) | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bug itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more check, including impacts. Currently the fix is from UI side.