Skip to content

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Apr 15, 2019

What changes were proposed in this pull request?

A followup of #24164

broadcast hint should be respected for broadcast nested loop join. This PR also refactors the related code a little bit, to save duplicated code.

How was this patch tested?

new tests

@cloud-fan
Copy link
Contributor Author

cc @maryannxue @gatorsmile

@cloud-fan cloud-fan changed the title [SPARK-27225][SQL] fix the join strategy for broadcast nested loop join [SPARK-27430][SQL] fix the join strategy for broadcast nested loop join Apr 15, 2019
@cloud-fan cloud-fan changed the title [SPARK-27430][SQL] fix the join strategy for broadcast nested loop join [SPARK-27430][SQL] broadcast hint should be respected for broadcast nested loop join Apr 15, 2019
@SparkQA
Copy link

SparkQA commented Apr 15, 2019

Test build #104596 has finished for PR 24376 at commit d69dda2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 15, 2019

Test build #104595 has finished for PR 24376 at commit 8369227.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maryannxue
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Apr 17, 2019

Test build #104641 has finished for PR 24376 at commit 9dc9dd1.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 17, 2019

Test build #104651 has finished for PR 24376 at commit 9dc9dd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

thanks, merging to master!

@cloud-fan cloud-fan closed this in e6618de Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants