[SPARK-27459][SQL] Revise the exception message of schema inference failure in file source V2 #24369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
felixcheung
reviewed
Apr 14, 2019
| testRead(spark.read.csv(), Seq.empty, schema) | ||
| }.getMessage | ||
| assert(message.toLowerCase(Locale.ROOT).contains("unable to infer schema for csv")) | ||
| assert(message.contains("Unable to infer schema for CSV. It must be specified manually.")) |
Member
There was a problem hiding this comment.
why remove toLowerCase(Locale.ROOT)?
Member
Author
There was a problem hiding this comment.
Because both V1 and V2 show exactly the same message.
toLowerCase(Locale.ROOT) was added in the migration of CSV V2 https://github.com/apache/spark/pull/24005/files#diff-b9ddfbc9be8d83ecf100b3b8ff9610b9R431
|
Test build #104576 has finished for PR 24369 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since https://github.com/apache/spark/pull/23383/files#diff-db4a140579c1ac4b1dbec7fe5057eecaR36, the exception message of schema inference failure in file source V2 is
tableName, which is equivalent toshortName + path.While in file source V1, the message is
Unable to infer schema from ORC/CSV/JSON....We should make the message in V2 consistent with V1, so that in the future migration the related test cases don't need to be modified. #24058 (review)
How was this patch tested?
Revert the modified unit test cases in https://github.com/apache/spark/pull/24005/files#diff-b9ddfbc9be8d83ecf100b3b8ff9610b9R431 and https://github.com/apache/spark/pull/23383/files#diff-9ab56940ee5a53f2bb81e3c008653362R577, and test with them.