Skip to content

[SPARK-26998][CORE] Remove SSL configuration from executors #24170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 10 commits into from
Closed

[SPARK-26998][CORE] Remove SSL configuration from executors #24170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0ef3f8b
[SPARK-26998][CORE] Add secure alternatives of ssl password parameters
gaborgsomogyi Mar 20, 2019
f6174a5
Add RAT excludes
gaborgsomogyi Mar 21, 2019
f26288d
Review fixes
gaborgsomogyi Mar 22, 2019
cfc46d6
Revert "Review fixes"
gaborgsomogyi Mar 26, 2019
c1157aa
Revert "Add RAT excludes"
gaborgsomogyi Mar 26, 2019
23e0908
Revert "[SPARK-26998][CORE] Add secure alternatives of ssl password p…
gaborgsomogyi Mar 26, 2019
a1aa23c
[SPARK-26998][CORE] Remove SSL configuration from executors
gaborgsomogyi Mar 26, 2019
72d8a78
Merge branch 'master' into SPARK-26998
gaborgsomogyi Apr 1, 2019
4695ea8
Merge branch 'master' into SPARK-26998
gaborgsomogyi Apr 1, 2019
fa8cdcd
Remove unnecessary validateSettings calls
gaborgsomogyi Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/SparkConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,6 @@ private[spark] object SparkConf extends Logging {
*/
def isExecutorStartupConf(name: String): Boolean = {
(name.startsWith("spark.auth") && name != SecurityManager.SPARK_AUTH_SECRET_CONF) ||
name.startsWith("spark.ssl") ||
name.startsWith("spark.rpc") ||
name.startsWith("spark.network") ||
isSparkPortConf(name)
Expand Down
11 changes: 11 additions & 0 deletions core/src/test/scala/org/apache/spark/SparkConfSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,17 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
}
}

test("SPARK-26998: SSL configuration not needed on executors") {
val conf = new SparkConf(false)
conf.set("spark.ssl.enabled", "true")
conf.set("spark.ssl.keyPassword", "password")
conf.set("spark.ssl.keyStorePassword", "password")
conf.set("spark.ssl.trustStorePassword", "password")

val filtered = conf.getAll.filter { case (k, _) => SparkConf.isExecutorStartupConf(k) }
assert(filtered.isEmpty)
}

test("SPARK-27244 toDebugString redacts sensitive information") {
val conf = new SparkConf(loadDefaults = false)
.set("dummy.password", "dummy-password")
Expand Down