Skip to content

[SPARK-27198][core] Heartbeat interval mismatch in driver and executor #24140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajithme wants to merge 10 commits into from
Closed

[SPARK-27198][core] Heartbeat interval mismatch in driver and executor #24140

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
12b53ee
fix interval to be uniform when no unit is mentioned
ajithme Mar 19, 2019
5755b31
handle magic number as per review comment
ajithme Mar 19, 2019
bc39695
handle non-unit time as millisecond
ajithme Mar 21, 2019
fb9ea5c
standardize heartbeat interval config
ajithme Mar 22, 2019
76570b7
update
ajithme Mar 22, 2019
596c9b2
update
ajithme Mar 24, 2019
c62330a
update
ajithme Mar 24, 2019
9941e93
update
ajithme Mar 24, 2019
39d9b59
updated
ajithme Mar 24, 2019
6c17bf8
update
ajithme Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/executor/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,9 @@ private[spark] class Executor(
* Schedules a task to report heartbeat and partial metrics for active tasks to driver.
*/
private def startDriverHeartbeater(): Unit = {
val intervalMs = conf.getTimeAsMs("spark.executor.heartbeatInterval", "10s")
val intervalMs = conf

@srowen srowen Mar 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In branch 2.4 this is accessed both with getTimeAsSeconds and getTimeAsMs, yes. The only question is which interpretation was intended? it's not a best practice to not specify the units, but hey it can happen.

In master, this is interpreted as milliseconds by default. I think we should instead switch how it's read in SparkConf instead?

@ajithme ajithme Mar 19, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, seems more reasonable as it also avoids the scenario @MaxGekk mentioned. Will modify the PR accordingly

.getTimeAsSeconds("spark.executor.heartbeatInterval", "10s") *
TimeUnit.SECONDS.toMillis(1)

// Wait a random interval so the heartbeats don't end up in sync
val initialDelay = intervalMs + (math.random * intervalMs).asInstanceOf[Int]
Expand Down