[SPARK-27197][SQL][TEST] Add ReadNestedSchemaTest for file-based data sources#24139
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-27197
Closed
[SPARK-27197][SQL][TEST] Add ReadNestedSchemaTest for file-based data sources#24139dongjoon-hyun wants to merge 2 commits intoapache:masterfrom dongjoon-hyun:SPARK-27197
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-27197
Conversation
Member
Author
|
cc @cloud-fan , @gatorsmile , @maropu , @dbtsai , @viirya , @HyukjinKwon . |
Member
|
LGTM. |
|
Test build #103653 has finished for PR 24139 at commit
|
Member
|
retest this please. |
viirya
approved these changes
Mar 19, 2019
maropu
reviewed
Mar 19, 2019
Member
|
It this pr related to #23964? |
|
Test build #103661 has finished for PR 24139 at commit
|
Member
Author
|
Yes. @maropu . There was a question about the other data sources (like Avro/JSON) works with nested column pruning. This PR verifies that explicitly. |
Member
Author
|
Test build #103676 has started for PR 24139 at commit |
Member
Author
|
Retest this please. |
maropu
approved these changes
Mar 19, 2019
Member
|
Thanks. Merged into master. |
Member
|
@dbtsai, tests were running and the last comments addressed are quite code changes ... |
|
Test build #103695 has finished for PR 24139 at commit
|
Member
Author
|
It passes finally. Thank you all, @dbtsai , @viirya , @maropu , @HyukjinKwon . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The reader schema is said to be evolved (or projected) when it changed after the data is written by writers. Apache Spark file-based data sources have a test coverage for that; e.g. ReadSchemaSuite.scala. This PR aims to add a test coverage for nested columns by adding and hiding nested columns.
How was this patch tested?
Pass the Jenkins with newly added tests.