[SPARK-27195][SQL][TEST] Add AvroReadSchemaSuite#24135
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-27195
Closed
[SPARK-27195][SQL][TEST] Add AvroReadSchemaSuite#24135dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-27195
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-27195
Conversation
Member
Author
dongjoon-hyun
commented
Mar 18, 2019
| extends ReadSchemaSuite | ||
| with AddColumnIntoTheMiddleTest | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest { |
Member
Author
There was a problem hiding this comment.
This is just a AS-IS Apache Spark supportability in Avro data sources.
Member
Author
|
Hi, @cloud-fan , @gatorsmile , @gengliangwang , @dbtsai . |
|
Test build #103629 has finished for PR 24135 at commit
|
HyukjinKwon
approved these changes
Mar 19, 2019
Member
Author
|
Thank you so much, @HyukjinKwon ! |
Member
|
A late LGTM 👍 |
Member
Author
|
Thank you, @gengliangwang ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The reader schema is said to be evolved (or projected) when it changed after the data is written by writers. Apache Spark file-based data sources have a test coverage for that, ReadSchemaSuite.scala. This PR aims to add
AvroReadSchemaSuiteto ensure the minimal consistency among file-based data sources and prevent a future regression in Avro data source.How was this patch tested?
Pass the Jenkins with the newly added test suite.