[SPARK-27193][SQL] CodeFormatter should format multiple comment lines correctly#24133
Closed
Ngone51 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-27193][SQL] CodeFormatter should format multiple comment lines correctly#24133Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
ping @cloud-fan @mgaido91 @sameeragarwal Can you have a look at this ? Thanks. |
Contributor
|
Not a big deal, but the change makes sense to me. |
|
Test build #103607 has finished for PR 24133 at commit
|
Contributor
|
thanks, merging to master! |
Member
Author
|
thank you @mgaido91 @cloud-fan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
when enable
spark.sql.codegen.comments, there will be multiple comment lines. However, CodeFormatter can not handle multiple comment lines currently:After applying this pr:
How was this patch tested?
Tested Manually.