Skip to content

[SPARK-22000][SQL][FOLLOW-UP] Fix bad test to ensure it can test properly #24112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HeartSaVioR wants to merge 1 commit into from
Closed

[SPARK-22000][SQL][FOLLOW-UP] Fix bad test to ensure it can test properly #24112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void testSpark22000() {

List<RecordSpark22000> records = dataset.collectAsList();

Assert.assertEquals(records, records);
Assert.assertEquals(expectedRecords, records);
}

@Test
Expand Down Expand Up @@ -211,7 +211,7 @@ private static RecordSpark22000 createRecordSpark22000(Row recordRow) {
record.setDoubleField(String.valueOf(recordRow.getDouble(4)));
record.setStringField(recordRow.getString(5));
record.setBooleanField(String.valueOf(recordRow.getBoolean(6)));
record.setTimestampField(String.valueOf(recordRow.getTimestamp(7).getTime() * 1000));
record.setTimestampField(String.valueOf(recordRow.getTimestamp(7)));
// This would figure out that null value will not become "null".
record.setNullIntField(null);
return record;
Expand Down