[SPARK-27159][SQL]update mssql server dialect to support binary type

[zhulipeng]

What changes were proposed in this pull request?

Change the binary type mapping from default blob to varbinary(max) for mssql server.
https://docs.microsoft.com/en-us/sql/t-sql/data-types/binary-and-varbinary-transact-sql?view=sql-server-2017

How was this patch tested?

Unit test.

[srowen]

What's the difference in SQL Server? I'm just wondering if there are any compatibility problems with older versions, or whether there's an upside to changing the type?

[dongjoon-hyun]

ok to test

[SparkQA]

Test build #103523 has finished for PR 24091 at commit fb6493e.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zhulipeng]

What's the difference in SQL Server? I'm just wondering if there are any compatibility problems with older versions, or whether there's an upside to changing the type?

What's the difference in SQL Server? I'm just wondering if there are any compatibility problems with older versions, or whether there's an upside to changing the type?

@srowen This is a bug fix for writing binary data back to MsSql Server.
#24099

spark/external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala

Line 170 in 9ee60a6

// df3.write.jdbc(jdbcUrl, "stringscopy", new Properties)

[SparkQA]

Test build #103527 has finished for PR 24091 at commit ebe4b93.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

What is this test that is failing -- something you have added locally? Looks OK though. Indeed BLOB doesn't seem to be supported.

[zhulipeng]

What is this test that is failing -- something you have added locally? Looks OK though. Indeed BLOB doesn't seem to be supported.

Yes, I just add a unit test to read/write Mssql Server through jdbc.

I have added this test case to MsSql server docker integration test suite in another PR. #24099

[srowen]

Merged to master

[dongjoon-hyun]

Hi, @lipzhu and @srowen .
I'll backport this bugfix to branch-2.4.

I did a clean cherry-pick to branch-2.4 and tested this locally.

Thank you, @lipzhu and @srowen .