Skip to content

Conversation

@sandeep-katta
Copy link
Contributor

@sandeep-katta sandeep-katta commented Mar 12, 2019

What changes were proposed in this pull request?

Hover is supported on the description column,so when the description column overflows user can view the complete details

How was this patch tested?

Manually

Before Fix

UIIssue

After Fix

e.g. 1
toolTip2
e.g. 2
ToolTipWithLargeQuery

@sandeep-katta
Copy link
Contributor Author

CC @vanzin @srowen @gengliangwang

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Mar 12, 2019

I think that's probably OK; does the cell expand automatically when you mouse over it?

@sandeep-katta
Copy link
Contributor Author

yes, it expands automatically as attached in the image

@gengliangwang
Copy link
Member

gengliangwang commented Mar 12, 2019

@sandeep-katta Thanks for the work.
I tried the patch. To me, the user experience is not very good. On mouse over, the table size is changed; if the mouse goes over table descriptions, then the table keep changing.

Personally, I prefer the way like tooltip:
image

Or showing the hidden part on click as SQL execution table:
image

@sandeep-katta
Copy link
Contributor Author

ok will work on tooltip and update the code accordingly

@sandeep-katta
Copy link
Contributor Author

With ToolTip it looks like below

toolTip2

With very large Query
ToolTipWithLargeQuery

@sandeep-katta sandeep-katta changed the title [SPARK-27135][WebUI]Add hover support for overflow text [SPARK-27135][WebUI]Add ToolTip support for overflow text Mar 13, 2019
@srowen
Copy link
Member

srowen commented Mar 13, 2019

I think that's good too, it's unobtrusive and gives the detail.

@sandeep-katta
Copy link
Contributor Author

@gengliangwang is this tooltip approach is okay ?

@gengliangwang
Copy link
Member

@sandeep-katta I took a look into this.
I found that there is already a double click event for showing the full description:
#6646

I am not sure about adding tooltip now.

@srowen
Copy link
Member

srowen commented Mar 15, 2019

Ha, I never realized that. I agree, we shouldn't add this then.

@srowen srowen closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants