[SPARK-27016][SQL][BUILD][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. #24060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le generating parser from the sql grammar file.
|
Test build #103349 has finished for PR 24060 at commit
|
Member
|
Nice. Thank you for fixing this from the upstream, @dilipbiswal ! |
Contributor
Author
|
@dongjoon-hyun Thank you :-) |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Mar 11, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending Jenkins).
The first build and second build verified this PR.
Member
|
+1 looks good |
|
Test build #103351 has finished for PR 24060 at commit
|
Member
|
Thank you, @dilipbiswal and @HyukjinKwon . |
Contributor
Author
|
Thanks a LOT @dongjoon-hyun @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the sbt maven plugin option
antlr4TreatWarningsAsErrorsto make sure the warnings are treated as errors while generating the parser. In the absence of it, we may inadvertently introduce problems while making grammar changes. Please refer to PR-23897 to know more about the context. We made a change in pr-23925 which handled only the maven build.In this PR, we handle the sbt build. I had submitted PR-23 to enhance the sbt-antlr plugin to make is possible to pass the error on warning option.
How was this patch tested?
Force an warning in the grammar file to check if the build fails. Then remove the warning to verify the build succeeds.