-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-27074][SQL][test-hadoop3.2][test-maven] Hive 3.1 metastore support HiveClientImpl.runHive #23992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Outdated
Show resolved
Hide resolved
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Outdated
Show resolved
Hide resolved
|
Test build #103099 has finished for PR 23992 at commit
|
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Show resolved
Hide resolved
|
Test build #105341 has finished for PR 23992 at commit
|
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Show resolved
Hide resolved
|
Test build #105359 has finished for PR 23992 at commit
|
| // But skip Hive 3.1 because of SPARK-27074. | ||
| if (version == "2.3") { | ||
| if (version == "2.3" || version == "3.1") { | ||
| val disableRewrite = if (version == "2.3") "" else "DISABLE REWRITE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment about the reason why we use DISABLE REWRITE in Hive 3.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Test build #105385 has finished for PR 23992 at commit
|
bin/spark-shell --conf spark.sql.hive.metastore.version=3.1.1 --conf spark.sql.hive.metastore.jars=maven |
|
Test build #105454 has finished for PR 23992 at commit
|
|
Retest this please. |
|
Test build #105550 has finished for PR 23992 at commit
|
|
retest this please |
|
Test build #105559 has finished for PR 23992 at commit
|
|
Retest this please. |
|
Retest this please. |
|
Test build #105791 has finished for PR 23992 at commit
|
|
Test build #105792 has finished for PR 23992 at commit
|
|
Retest this please. |
|
Test build #105795 has finished for PR 23992 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @wangyum .
Merged to master.
What changes were proposed in this pull request?
Hive 3.1.1's
CommandProcessorhave 2 changes:spark/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
Lines 736 to 742 in 02bbe97
We can disable
hive.query.reexecution.enabledto workaround this change.Driver.close()function return type. We can workaround it bydriver.getClass.getMethod("close").invoke(driver)So Hive 3.1 metastore could support
HiveClientImpl.runHiveafter this pr.How was this patch tested?
unit tests