Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Mar 6, 2019

What changes were proposed in this pull request?

Hive 3.1.1's CommandProcessor have 2 changes:

  1. HIVE-17626(Hive 3.0.0) add ReExecDriver. So the current code path is:
    case _ =>
    if (state.out != null) {
    // scalastyle:off println
    state.out.println(tokens(0) + " " + cmd_1)
    // scalastyle:on println
    }
    Seq(proc.run(cmd_1).getResponseCode.toString)

    We can disable hive.query.reexecution.enabled to workaround this change.
  2. HIVE-18238(Hive 3.0.0) changed the Driver.close() function return type. We can workaround it by driver.getClass.getMethod("close").invoke(driver)

So Hive 3.1 metastore could support HiveClientImpl.runHive after this pr.

How was this patch tested?

unit tests

@SparkQA
Copy link

SparkQA commented Mar 6, 2019

Test build #103099 has finished for PR 23992 at commit 513098c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-27074][SQL] Refactor HiveClientImpl.runHive [SPARK-27074][SQL] Hive 3.1 metastore support HiveClientImpl.runHive May 12, 2019
@SparkQA
Copy link

SparkQA commented May 12, 2019

Test build #105341 has finished for PR 23992 at commit c266a8e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented May 13, 2019

cc @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented May 13, 2019

Test build #105359 has finished for PR 23992 at commit 53ed19d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

// But skip Hive 3.1 because of SPARK-27074.
if (version == "2.3") {
if (version == "2.3" || version == "3.1") {
val disableRewrite = if (version == "2.3") "" else "DISABLE REWRITE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about the reason why we use DISABLE REWRITE in Hive 3.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkQA
Copy link

SparkQA commented May 14, 2019

Test build #105385 has finished for PR 23992 at commit 38cd028.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented May 15, 2019

how can we build against the Hive 3.1 metastore to test? Or do we just have to manually provide hive 3.1 jars for now.

bin/spark-shell --conf spark.sql.hive.metastore.version=3.1.1 --conf spark.sql.hive.metastore.jars=maven

@SparkQA
Copy link

SparkQA commented May 16, 2019

Test build #105454 has finished for PR 23992 at commit 7cf2875.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented May 20, 2019

Test build #105550 has finished for PR 23992 at commit 7cf2875.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented May 20, 2019

retest this please

@SparkQA
Copy link

SparkQA commented May 20, 2019

Test build #105559 has finished for PR 23992 at commit 7cf2875.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27074][SQL] Hive 3.1 metastore support HiveClientImpl.runHive [SPARK-27074][SQL][test-hadoop3.2][test-maven] Hive 3.1 metastore support HiveClientImpl.runHive May 26, 2019
@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented May 26, 2019

Test build #105791 has finished for PR 23992 at commit 7cf2875.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 26, 2019

Test build #105792 has finished for PR 23992 at commit 7cf2875.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented May 26, 2019

Retest this please.

@SparkQA
Copy link

SparkQA commented May 26, 2019

Test build #105795 has finished for PR 23992 at commit 7cf2875.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @wangyum .

Merged to master.

@wangyum wangyum deleted the SPARK-27074 branch May 26, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants