Skip to content

[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternalCatalogVersionsSuite #23807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maropu wants to merge 1 commit into from
Closed

[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternalCatalogVersionsSuite #23807

maropu wants to merge 1 commit into from

Conversation

@maropu
Copy link
Member

@maropu maropu commented Feb 16, 2019

What changes were proposed in this pull request?

The maintenance release of branch-2.3 (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

How was this patch tested?

Pass the Jenkins.

@maropu
Copy link
Member Author

maropu commented Feb 16, 2019

Also, it seems we could drop these lines:
https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala#L264-L269

@SparkQA
Copy link

SparkQA commented Feb 16, 2019

Test build #102406 has finished for PR 23807 at commit 799a01a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Feb 16, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Feb 16, 2019

Test build #102415 has finished for PR 23807 at commit 799a01a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Feb 16, 2019 •
edited
Loading

Hi, @maropu . Finally! Nice, but shall we wait for a while? This should be done after all mirrors got 2.3.3.

@maropu
Copy link
Member Author

maropu commented Feb 16, 2019

oh, I see...

@srowen
Copy link
Member

srowen commented Feb 17, 2019

You are welcome to drop those additional lines. We should be Ok to merge as the release is on the mirrors now, but it wouldn't fail if not anyway.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Feb 17, 2019

Retest this please.

dongjoon-hyun
dongjoon-hyun approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

@SparkQA
Copy link

SparkQA commented Feb 17, 2019

Test build #102432 has finished for PR 23807 at commit 799a01a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

maropu added a commit that referenced this pull request Feb 17, 2019
@maropu
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
dfda97a 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes #23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit dcdbd06)
Signed-off-by: Takeshi Yamamuro <[email protected]>
@maropu
Copy link
Member Author

maropu commented Feb 17, 2019

Thanks! Merged to master/branch2.4.
This fix is conflict with branch-2.3, so I'll make a pr in follow-up.

@maropu maropu closed this Feb 17, 2019
maropu added a commit that referenced this pull request Feb 17, 2019
@maropu
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
dcdbd06 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes #23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Feb 18, 2019
Merged
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@maropu
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
eca472c 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes apache#23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
@maropu @kai-chi
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
6cc7d8b 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes apache#23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit dcdbd06)
Signed-off-by: Takeshi Yamamuro <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
@maropu @kai-chi
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
68f7ace 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes apache#23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit dcdbd06)
Signed-off-by: Takeshi Yamamuro <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
@maropu @kai-chi
[SPARK-26897][SQL][TEST] Update Spark 2.3.x testing from HiveExternal…
c83381e 
…CatalogVersionsSuite

## What changes were proposed in this pull request?
The maintenance release of `branch-2.3` (v2.3.3) vote passed, so this issue updates PROCESS_TABLES.testingVersions in HiveExternalCatalogVersionsSuite

## How was this patch tested?
Pass the Jenkins.

Closes apache#23807 from maropu/SPARK-26897.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit dcdbd06)
Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maropu @SparkQA @dongjoon-hyun @srowen