Skip to content

[SPARK-3518] Remove wasted statement in JsonProtocol #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-3518] Remove wasted statement in JsonProtocol #2380

wants to merge 2 commits into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Sep 13, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2380 at commit c660fbc.

  • This patch merges cleanly.

srowen
srowen reviewed Sep 13, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala Outdated
Copy link
Member

@srowen srowen Sep 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just remove the unused accumUpdateMap instead and preserve the symmetry? This is a simple getter, which would be inlined anyway. This also seems very trivial.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2380 at commit b6ca544.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2380 at commit 8a1464e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2380 at commit c660fbc.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2380 at commit b6ca544.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2380 at commit 8a1464e.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in e59fac1 Sep 15, 2014
asfgit pushed a commit that referenced this pull request Sep 15, 2014
@sarutak @pwendell
[SPARK-3518] Remove wasted statement in JsonProtocol
99a6c5e 
Author: Kousuke Saruta <[email protected]>

Closes #2380 from sarutak/SPARK-3518 and squashes the following commits:

8a1464e [Kousuke Saruta] Replaced a variable with simple field reference
c660fbc [Kousuke Saruta] Removed useless statement in JsonProtocol.scala

(cherry picked from commit e59fac1)
Signed-off-by: Patrick Wendell <[email protected]>
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Sep 19, 2014
@sarutak @markhamstra
[SPARK-3518] Remove wasted statement in JsonProtocol
8bf69ab 
Author: Kousuke Saruta <[email protected]>

Closes apache#2380 from sarutak/SPARK-3518 and squashes the following commits:

8a1464e [Kousuke Saruta] Replaced a variable with simple field reference
c660fbc [Kousuke Saruta] Removed useless statement in JsonProtocol.scala

(cherry picked from commit e59fac1)
Signed-off-by: Patrick Wendell <[email protected]>
@sarutak sarutak deleted the SPARK-3518 branch April 11, 2015 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarutak @SparkQA @srowen