Skip to content

[SPARK-3515][SQL] Moves test suite setup code to beforeAll rather than in constructor #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-3515][SQL] Moves test suite setup code to beforeAll rather than in constructor #2375

wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Sep 13, 2014

Please refer to the JIRA ticket for details.

NOTE We should check all test suites that do similar initialization-like side effects in their constructors. This PR only fixes ParquetMetastoreSuite because it breaks our Jenkins Maven build.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2375 at commit 0ceb75b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2375 at commit 0ceb75b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • throw new IllegalStateException("The main method in the given main class must be static")

@asfgit asfgit closed this in 6d887db Sep 13, 2014
@marmbrus
Copy link
Contributor

marmbrus commented Sep 13, 2014

Thanks! Merged.

asfgit pushed a commit that referenced this pull request Sep 13, 2014
@liancheng @marmbrus
[SPARK-3515][SQL] Moves test suite setup code to beforeAll rather tha…
44e534e 
…n in constructor

Please refer to the JIRA ticket for details.

**NOTE** We should check all test suites that do similar initialization-like side effects in their constructors. This PR only fixes `ParquetMetastoreSuite` because it breaks our Jenkins Maven build.

Author: Cheng Lian <[email protected]>

Closes #2375 from liancheng/say-no-to-constructor and squashes the following commits:

0ceb75b [Cheng Lian] Moves test suite setup code to beforeAll rather than in constructor

(cherry picked from commit 6d887db)
Signed-off-by: Michael Armbrust <[email protected]>
@liancheng liancheng deleted the say-no-to-constructor branch September 13, 2014 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liancheng @SparkQA @marmbrus