-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26726] Synchronize the amount of memory used by the broadcast variable to the UI display #23649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26726] Synchronize the amount of memory used by the broadcast variable to the UI display #23649
Changes from 2 commits
2459342
a51ea3e
e9d0f18
53cbc0b
b4d6996
221bf77
2024976
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -827,6 +827,7 @@ private[spark] class AppStatusListener( | |
| event.blockUpdatedInfo.blockId match { | ||
| case block: RDDBlockId => updateRDDBlock(event, block) | ||
| case stream: StreamBlockId => updateStreamBlock(event, stream) | ||
| case broadcast: BroadcastBlockId => updateBroadcastBlock(event, broadcast) | ||
| case _ => | ||
| } | ||
| } | ||
|
|
@@ -995,6 +996,34 @@ private[spark] class AppStatusListener( | |
| } | ||
| } | ||
|
|
||
| private def updateBroadcastBlock(event: SparkListenerBlockUpdated, | ||
| broadcast: BroadcastBlockId): Unit = { | ||
| val now = System.nanoTime() | ||
| val executorId = event.blockUpdatedInfo.blockManagerId.executorId | ||
| val storageLevel = event.blockUpdatedInfo.storageLevel | ||
|
|
||
| // Whether values are being added to or removed from the existing accounting. | ||
| val diskDelta = event.blockUpdatedInfo.diskSize * (if (storageLevel.useDisk) 1 else -1) | ||
| val memoryDelta = event.blockUpdatedInfo.memSize * (if (storageLevel.useMemory) 1 else -1) | ||
|
|
||
| // Function to apply a delta to a value, but ensure that it doesn't go negative. | ||
| def newValue(old: Long, delta: Long): Long = math.max(0, old + delta) | ||
|
||
|
|
||
| val maybeExec = liveExecutors.get(executorId) | ||
| maybeExec.foreach { exec => | ||
|
||
| if (exec.hasMemoryInfo) { | ||
|
||
| if (storageLevel.useOffHeap) { | ||
| exec.usedOffHeap = newValue(exec.usedOffHeap, memoryDelta) | ||
| } else { | ||
| exec.usedOnHeap = newValue(exec.usedOnHeap, memoryDelta) | ||
| } | ||
| } | ||
| exec.memoryUsed = newValue(exec.memoryUsed, memoryDelta) | ||
| exec.diskUsed = newValue(exec.diskUsed, diskDelta) | ||
| maybeUpdate(exec, now) | ||
| } | ||
| } | ||
|
|
||
| private def getOrCreateStage(info: StageInfo): LiveStage = { | ||
| val stage = liveStages.computeIfAbsent((info.stageId, info.attemptNumber), | ||
| new Function[(Int, Int), LiveStage]() { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multi line args start on the next line.