Skip to content

[SPARK-26554][BUILD] Update release-util.sh to avoid GitBox fake 200 headers #23476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-26554][BUILD] Update release-util.sh to avoid GitBox fake 200 headers #23476

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
241c288
[SPARK-26554][BUILD] Update `release-util.sh` to avoid GitBox fake 20…
dongjoon-hyun Jan 6, 2019
3178a69
Add comments
dongjoon-hyun Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/create-release/release-util.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function fcreate_secure {
}

function check_for_tag {
curl -s --head --fail "$ASF_REPO_WEBUI;a=commit;h=$1" >/dev/null
! curl -s --fail "$ASF_REPO_WEBUI;a=commit;h=$1" | grep '404 Not Found' > /dev/null
Copy link
Member

@srowen srowen Jan 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the ! do -- make this fail if grep successfully found a 404? does grep -v get the same effect? No need to change it, it's fine, just curious

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review and approval, @srowen . Yes, right. ! does.
We cannot use grep -v which matches all the other lines doesn't have 404 Not Found. grep only returns 1 when no lines are selected.

Copy link
Member

@srowen srowen Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, duh, wasn't thinking it through

}

function get_release_info {
Expand Down