[SPARK-26306][TEST][BUILD] More memory to de-flake SorterSuite #23425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #100634 has finished for PR 23425 at commit
|
Member
|
retest this please. |
|
Test build #100637 has finished for PR 23425 at commit
|
Member
|
Thank you for making this PR. I know that we are very conservative in this area, but I'm +1 for this PR. @rxin and @aarondav . Since SPARK-26306 is related to SPARK-5984, could you give us some advice for this PR? |
Member
Author
|
Merged to master |
srowen
added a commit
that referenced
this pull request
Jan 4, 2019
## What changes were proposed in this pull request? Increase test memory to avoid OOM in TimSort-related tests. ## How was this patch tested? Existing tests. Closes #23425 from srowen/SPARK-26306. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Member
|
It's great. Thank you, @srowen ! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Increase test memory to avoid OOM in TimSort-related tests. ## How was this patch tested? Existing tests. Closes apache#23425 from srowen/SPARK-26306. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Increase test memory to avoid OOM in TimSort-related tests.
How was this patch tested?
Existing tests.