Skip to content

[SPARK-26415][SQL] Mark StreamSinkProvider and StreamSourceProvider as stable #23354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
granthenke wants to merge 1 commit into from
Closed

[SPARK-26415][SQL] Mark StreamSinkProvider and StreamSourceProvider as stable #23354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,11 @@ trait SchemaRelationProvider {
}

/**
* ::Experimental::
* Implemented by objects that can produce a streaming `Source` for a specific format or system.
*
* @since 2.0.0
*/
@Experimental
@Unstable
@Stable
Copy link
Member

@HyukjinKwon HyukjinKwon Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, unstable to stable sounds a big jump tho. Maybe Evolving or simply removing Unstable can be a okay compromise if we're not sure on this.

Copy link
Member

@HyukjinKwon HyukjinKwon Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tdas and @zsxwing

Copy link
Member Author

@granthenke granthenke Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon I don't think it makes sense to go through the motions step by step just for the sake of taking the steps. This interface has gone unchanged since Spark 2.2.0.

trait StreamSourceProvider {
Copy link
Contributor

@cloud-fan cloud-fan Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is stable, I think Source and Sink need to be stable as well?

Copy link
Member Author

@granthenke granthenke Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source and Sink do not have any annotations on them. Does that imply they are stable? Sink and Source are exposed/returned in the DataSource class today as well.

I am happy to add a Stable annotation if that is your recommendation.


/**
Expand All @@ -142,13 +140,11 @@ trait StreamSourceProvider {
}

/**
* ::Experimental::
* Implemented by objects that can produce a streaming `Sink` for a specific format or system.
*
* @since 2.0.0
*/
@Experimental
@Unstable
@Stable
trait StreamSinkProvider {
def createSink(
sqlContext: SQLContext,
Expand Down