Skip to content

[SPARK-26307] [SQL] Fix CTAS when INSERT a partitioned table using Hive serde #23255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 2 commits into from
Closed

[SPARK-26307] [SQL] Fix CTAS when INSERT a partitioned table using Hive serde #23255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
921967b
fix.
gatorsmile Dec 7, 2018
68c076a
added the JIRA number
gatorsmile Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...e/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ case class CreateHiveTableAsSelectCommand(
return Seq.empty
}

// For CTAS, there is no static partition values to insert.
val partition = tableDesc.partitionColumnNames.map(_ -> None).toMap
Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically, this happens not only CTAS but also INSERT. Never mind.

InsertIntoHiveTable(
tableDesc,
Map.empty,
partition,
query,
overwrite = false,
ifPartitionNotExists = false,
Expand Down
11 changes: 11 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,17 @@ class InsertSuite extends QueryTest with TestHiveSingleton with BeforeAndAfter
}
}

test("SPARK-26307: CTAS - INSERT a partitioned table using Hive serde") {
withTable("tab1") {
withSQLConf("hive.exec.dynamic.partition.mode" -> "nonstrict") {
val df = Seq(("a", 100)).toDF("part", "id")
df.write.format("hive").partitionBy("part").mode("overwrite").saveAsTable("tab1")
df.write.format("hive").partitionBy("part").mode("append").saveAsTable("tab1")
}
}
}


Seq("LOCAL", "").foreach { local =>
Seq(true, false).foreach { caseSensitivity =>
Seq("orc", "parquet").foreach { format =>
Expand Down