Skip to content

[SPARK-25498][SQL][FOLLOW-UP] Return an empty config set when regenerating the golden files #23212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 1 commit into from
Closed

[SPARK-25498][SQL][FOLLOW-UP] Return an empty config set when regenerating the golden files #23212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,10 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
val (conf, value) = confAndValue.span(_ != '=')
conf.trim -> value.substring(1).trim
})
// When we are regenerating the golden files we don't need to run all the configs as they
// When we are regenerating the golden files, we don't need to set any config as they
// all need to return the same result
if (regenerateGoldenFiles) {
if (configs.nonEmpty) {
configs.take(1)
} else {
Array.empty[Array[(String, String)]]
}
Array.empty[Array[(String, String)]]
} else {
if (configs.nonEmpty) {
codegenConfigSets.flatMap { codegenConfig =>
Expand Down