Add ValueIncrementableHashMapAccumulator #2314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
QA tests have started for PR 2314 at commit
|
Contributor
|
Thanks for the PR but this doesn't seem like something that needs to be in Spark -- we already have a histogram() implementation, and users can always build their own accumulator. I think that by the time people figure out this exists, they could've built their own class in this case. |
Contributor
|
Let's close this issue, in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueIncrementableHashMapAccumulator can be used in Spark Accumulator functionality to compute Histograms, distributions, complex metrics, etc.
https://issues.apache.org/jira/browse/SPARK-3430