-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26026][BUILD] Published Scaladoc jars missing from Maven Central #23069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd qualify a few inner classes to make scaladoc work.
|
Test build #98964 has finished for PR 23069 at commit
|
|
Test build #4430 has finished for PR 23069 at commit
|
|
Test build #4432 has finished for PR 23069 at commit
|
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, how do we check for these kind of things in the future?
|
How do we check if doc artifacts were built? well, honestly we (meaning, I) should have noticed this in our releases. Docs were obviously generated for the public site, just not the artifacts that get downloaded into IDEs. Now, the artifacts are always built with the build, so we'll notice if it breaks. We'll also get a lot of build warnings (again), which we may not like, and decide to put this behind the release profile. And then deal with (rare?) breakage at release time. |
|
Merged to master |
## What changes were proposed in this pull request? This restores scaladoc artifact generation, which got dropped with the Scala 2.12 update. The change looks large, but is almost all due to needing to make the InterfaceStability annotations top-level classes (i.e. `InterfaceStability.Stable` -> `Stable`), unfortunately. A few inner class references had to be qualified too. Lots of scaladoc warnings now reappear. We can choose to disable generation by default and enable for releases, later. ## How was this patch tested? N/A; build runs scaladoc now. Closes #23069 from srowen/SPARK-26026. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
|
Is it a requirement to put annotation class top level? |
|
Yeah, or at least so claims Scala 2.12. Java evidently doesn't object. |
## What changes were proposed in this pull request? This restores scaladoc artifact generation, which got dropped with the Scala 2.12 update. The change looks large, but is almost all due to needing to make the InterfaceStability annotations top-level classes (i.e. `InterfaceStability.Stable` -> `Stable`), unfortunately. A few inner class references had to be qualified too. Lots of scaladoc warnings now reappear. We can choose to disable generation by default and enable for releases, later. ## How was this patch tested? N/A; build runs scaladoc now. Closes apache#23069 from srowen/SPARK-26026. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
What changes were proposed in this pull request?
This restores scaladoc artifact generation, which got dropped with the Scala 2.12 update. The change looks large, but is almost all due to needing to make the InterfaceStability annotations top-level classes (i.e.
@InterfaceStability.Stable->@Stable), unfortunately. A few inner class references had to be qualified too.Lots of scaladoc warnings now reappear. We can choose to disable generation by default and enable for releases, later.
How was this patch tested?
N/A; build runs scaladoc now.