Skip to content

[minor] update HiveExternalCatalogVersionsSuite to test 2.4.0 #22984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 2 commits into from
Closed

[minor] update HiveExternalCatalogVersionsSuite to test 2.4.0 #22984

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9817b4
update HiveExternalCatalogVersionsSuite to test 2.4.0
cloud-fan Nov 8, 2018
30ff297
drop 2.1
cloud-fan Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {

object PROCESS_TABLES extends QueryTest with SQLTestUtils {
// Tests the latest version of every release line.
val testingVersions = Seq("2.1.3", "2.2.2", "2.3.2")
val testingVersions = Seq("2.1.3", "2.2.2", "2.3.2", "2.4.0")

@cloud-fan cloud-fan Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will we drop 2.1 officially?

@srowen srowen Nov 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1 should be removed actually. At least according to our default 18-month support rule, it ended support in June 2018, and I see no desire for a 2.1.4 release. 2.2 will end in Jan 2019 according to the same guideline. It's not a hard rule, but probably the right guidance to follow.

Certainly, as this test takes a while and can be flaky I'd like to keep it to 3 versions.


protected var spark: SparkSession = _

Expand Down