[SPARK-25676][FOLLOWUP][BUILD] Fix Scala 2.12 build error #22970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dbtsai . The PR is ready. Could you review this? |
Member
|
LGTM. Thanks. |
Member
|
Merged into master as the compilation finished. Thanks! |
Member
Author
|
Thank you, @dbtsai ! |
|
Test build #98578 has finished for PR 22970 at commit
|
Member
Author
|
The failures are irrelevant to this PR because this PR only updates benchmark code. |
cloud-fan
reviewed
Nov 8, 2018
| benchmark.addCase(s"split threshold $n", numIters = 5) { iter => | ||
| withSQLConf(SQLConf.CODEGEN_METHOD_SPLIT_THRESHOLD.key -> n) { | ||
| df.selectExpr(columns: _*).foreach(identity(_)) | ||
| df.selectExpr(columns: _*).foreach((x => x): Row => Unit) |
Contributor
There was a problem hiding this comment.
shall we use foreach(_ => ())?
Member
Author
There was a problem hiding this comment.
Sure. I'll try to make another follow-ups with the benchmark result.
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2018
## What changes were proposed in this pull request? #22970 fixed Scala 2.12 build error, and this PR updates the function according to the review comments. ## How was this patch tested? This is also manually tested with Scala 2.12 build. Closes #22978 from dongjoon-hyun/SPARK-25676-3. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR fixes the Scala-2.12 build. ## How was this patch tested? Manual build with Scala-2.12 profile. Closes apache#22970 from dongjoon-hyun/SPARK-25676-2.12. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: DB Tsai <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? apache#22970 fixed Scala 2.12 build error, and this PR updates the function according to the review comments. ## How was this patch tested? This is also manually tested with Scala 2.12 build. Closes apache#22978 from dongjoon-hyun/SPARK-25676-3. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the Scala-2.12 build.
How was this patch tested?
Manual build with Scala-2.12 profile.