[SPARK-25864][SQL][TEST] Make main args accessible for BenchmarkBase's subclass #22872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
approved these changes
Oct 29, 2018
Contributor
|
ok to test |
Contributor
|
add to whitelist |
|
Test build #98188 has finished for PR 22872 at commit
|
Member
|
retest this please |
|
Test build #98187 has finished for PR 22872 at commit
|
Contributor
Author
|
@HyukjinKwon @cloud-fan My previous tests have been passed :). |
|
Test build #98185 has finished for PR 22872 at commit
|
Contributor
|
thanks, merging to master! |
|
Test FAILed. |
This was referenced Oct 29, 2018
Member
|
Thank you, @yucai , @cloud-fan , @HyukjinKwon . |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…s subclass ## What changes were proposed in this pull request? Set main args correctly in BenchmarkBase, to make it accessible for its subclass. It will benefit: - BuiltInDataSourceWriteBenchmark - AvroWriteBenchmark ## How was this patch tested? manual tests Closes apache#22872 from yucai/main_args. Authored-by: yucai <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set main args correctly in BenchmarkBase, to make it accessible for its subclass.
It will benefit:
How was this patch tested?
manual tests