[SPARK-25656][SQL][DOC][EXAMPLE] Add a doc and examples about extra data source options #22801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource save options
dongjoon-hyun
commented
Oct 23, 2018
| OPTIONS ( | ||
| orc.bloom.filter.columns 'favorite_color', | ||
| orc.dictionary.key.threshold '1.0', | ||
| orc.column.encoding.direct 'name' |
Member
Author
There was a problem hiding this comment.
Could you review this, @gatorsmile ? This is the example we discussed previously.
dongjoon-hyun
changed the title
|
Test build #97900 has finished for PR 22801 at commit
|
dongjoon-hyun
commented
Oct 23, 2018
| .option("orc.bloom.filter.columns", "favorite_color") | ||
| .option("orc.dictionary.key.threshold", "1.0") | ||
| .option("orc.column.encoding.direct", "name") | ||
| .save("users_with_options.orc") |
Member
Author
There was a problem hiding this comment.
Also, cc @dbtsai .
This doc is only for Spark 3.0.0 since orc.column.encoding.direct is added to master branch.
|
Test build #97926 has finished for PR 22801 at commit
|
dongjoon-hyun
commented
Oct 23, 2018
| # $example on:manual_save_options_orc$ | ||
| df <- read.df("examples/src/main/resources/users.orc", "orc") | ||
| write.orc(df, "users_with_options.orc", orc.bloom.filter.columns="favorite_color", orc.dictionary.key.threshold=1.0, orc.column.encoding.direct="name") | ||
| # $example off:manual_save_options_orc$ |
Member
There was a problem hiding this comment.
we should put space after param
(gosh same for csv example above)
orc.bloom.filter.columns = "favorite_color", orc.dictionary.key.threshold = 1.0, orc.column.encoding.direct = "name")
felixcheung
reviewed
Oct 23, 2018
| # $example on:manual_save_options_orc$ | ||
| df <- read.df("examples/src/main/resources/users.orc", "orc") | ||
| write.orc(df, "users_with_options.orc", orc.bloom.filter.columns="favorite_color", orc.dictionary.key.threshold=1.0, orc.column.encoding.direct="name") | ||
| # $example off:manual_save_options_orc$ |
Member
There was a problem hiding this comment.
we should put space after param
(gosh same for csv example above)
orc.bloom.filter.columns = "favorite_color", orc.dictionary.key.threshold = 1.0, orc.column.encoding.direct = "name")
| (df.write.format("orc") | ||
| .option("orc.bloom.filter.columns", "favorite_color") | ||
| .option("orc.dictionary.key.threshold", "1.0") | ||
| .option("orc.column.encoding.direct", 'name') |
Member
There was a problem hiding this comment.
use same quote? " or ' for name?
|
Test build #97932 has finished for PR 22801 at commit
|
|
Test build #97933 has finished for PR 22801 at commit
|
Member
|
This LGTM. |
Member
Author
|
Thank you for review, @felixcheung , @dbtsai , @HyukjinKwon . |
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2018
…bout extra data source options ## What changes were proposed in this pull request? Our current doc does not explain how we are passing the data source specific options to the underlying data source. According to [the review comment](#22622 (comment)), this PR aims to add more detailed information and examples. This is a backport of #22801. `orc.column.encoding.direct` is removed since it's not supported in ORC 1.5.2. ## How was this patch tested? Manual. Closes #22839 from dongjoon-hyun/SPARK-25656-2.4. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ata source options ## What changes were proposed in this pull request? Our current doc does not explain how we are passing the data source specific options to the underlying data source. According to [the review comment](apache#22622 (comment)), this PR aims to add more detailed information and examples ## How was this patch tested? Manual. Closes apache#22801 from dongjoon-hyun/SPARK-25656. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Our current doc does not explain how we are passing the data source specific options to the underlying data source. According to the review comment, this PR aims to add more detailed information and examples
How was this patch tested?
Manual.