Skip to content

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Oct 23, 2018

What changes were proposed in this pull request?

This PR replaces turing with tuning in files and a file name. Currently, in the left side menu, Turing is shown. This page is one of examples.
image

How was this patch tested?

grep -rin turing docs && find docs -name "*turing*"

@kiszk
Copy link
Member Author

kiszk commented Oct 23, 2018

@SparkQA
Copy link

SparkQA commented Oct 23, 2018

Test build #97895 has finished for PR 22800 at commit a13493b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM

@cloud-fan
Copy link
Contributor

thanks, merging to master/2.4!

asfgit pushed a commit that referenced this pull request Oct 23, 2018
## What changes were proposed in this pull request?

This PR replaces `turing` with `tuning` in files and a file name. Currently, in the left side menu, `Turing` is shown. [This page](https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc4-docs/_site/sql-performance-turing.html) is one of examples.
![image](https://user-images.githubusercontent.com/1315079/47332714-20a96180-d6bb-11e8-9a5a-0a8dad292626.png)

## How was this patch tested?

`grep -rin turing docs` && `find docs -name "*turing*"`

Closes #22800 from kiszk/SPARK-24499-follow.

Authored-by: Kazuaki Ishizaki <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit c391dc6)
Signed-off-by: Wenchen Fan <[email protected]>
@asfgit asfgit closed this in c391dc6 Oct 23, 2018
Copy link
Member

@xuanyuanking xuanyuanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late +1, thanks for the fix.
There are also typo on turning in sql-getting-started.md/sql-performance-turing.md/tuning.md. Will give a PR together when find more.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This PR replaces `turing` with `tuning` in files and a file name. Currently, in the left side menu, `Turing` is shown. [This page](https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc4-docs/_site/sql-performance-turing.html) is one of examples.
![image](https://user-images.githubusercontent.com/1315079/47332714-20a96180-d6bb-11e8-9a5a-0a8dad292626.png)

## How was this patch tested?

`grep -rin turing docs` && `find docs -name "*turing*"`

Closes apache#22800 from kiszk/SPARK-24499-follow.

Authored-by: Kazuaki Ishizaki <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants