Skip to content

[SPARK-25795][R][EXAMPLE] Fix CSV SparkR SQL Example #22791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-25795][R][EXAMPLE] Fix CSV SparkR SQL Example #22791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/src/main/r/RSparkSQLExample.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet", "parquet")


# $example on:manual_load_options_csv$
df <- read.df("examples/src/main/resources/people.csv", "csv")
df <- read.df("examples/src/main/resources/people.csv", "csv", sep=";", inferSchema=T, header=T)
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @felixcheung .
Could you review this?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ping @jomach and @gatorsmile because it was added by the following PR at Spark 2.3.

BTW, SPARK-20055 is still open.

Copy link
Member

@felixcheung felixcheung Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in R style we typical put space after param name, ie. https://github.com/apache/spark/pull/22791/files#diff-eeffb959b904ebb5c864bc3dafe6437dR168
, sep = ";", inferSchema = TRUE, header = TRUE

and pls don't use T for readability

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixcheung .

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, I included that here

namesAndAges <- select(df, "name", "age")
# $example off:manual_load_options_csv$

Expand Down