[SPARK-25779][SQL][TESTS] Remove SQL query tests for function documentation by DESCRIBE FUNCTION at SQLQueryTestSuite#22776
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
|
Test build #97609 has finished for PR 22776 at commit
|
dongjoon-hyun
approved these changes
Oct 19, 2018
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
cc @gatorsmile
…N at SQLQueryTestSuite
HyukjinKwon
force-pushed
the
SPARK-25779
branch
from
7f4cd6d to
7b1490a
Compare
|
Test build #97635 has finished for PR 22776 at commit
|
Member
|
Retest this please. |
|
Test build #97641 has finished for PR 22776 at commit
|
Member
Author
|
retest this please |
|
Test build #97648 has finished for PR 22776 at commit
|
Member
Author
|
retest this please |
|
Test build #97660 has finished for PR 22776 at commit
|
Member
|
Merged to master. Thank you, @HyukjinKwon ! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…tation by DESCRIBE FUNCTION at SQLQueryTestSuite Currently, there are some tests testing function descriptions: ```bash $ grep -ir "describe function" sql/core/src/test/resources/sql-tests/inputs sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function to_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function extended to_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function from_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function extended from_json; ``` Looks there are not quite good points about testing them since we're not going to test documentation itself. For `DESCRIBE FCUNTION` functionality itself, they are already being tested here and there. See the test failures in apache#18749 (where I added examples to function descriptions) We better remove those tests so that people don't add such tests in the SQL tests. ## How was this patch tested? Manual. Closes apache#22776 from HyukjinKwon/SPARK-25779. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are some tests testing function descriptions:
Looks there are not quite good points about testing them since we're not going to test documentation itself.
For
DESCRIBE FCUNTIONfunctionality itself, they are already being tested here and there.See the test failures in #18749 (where I added examples to function descriptions)
We better remove those tests so that people don't add such tests in the SQL tests.
How was this patch tested?
Manual.