Skip to content

Conversation

@dilipbiswal
Copy link
Contributor

What changes were proposed in this pull request?

Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-)

How was this patch tested?

Built using jekyll and verified the links.

@dilipbiswal
Copy link
Contributor Author

@SparkQA
Copy link

SparkQA commented Oct 19, 2018

Test build #97567 has finished for PR 22772 at commit 2048c39.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

I think we better do some proof readings before doing multiple minor followups.

@dilipbiswal
Copy link
Contributor Author

@HyukjinKwon Sure. If there are more changes planned in another PR, then it can take these changes in. Since this went to 2.4, i thought there may be some urgency to fix the links.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 19, 2018

Minor fixes are minor .. no need to rush to get this into 2.4. Let's take a look few more times before going ahead. We can just directly open a PR to your branch here as well if anyone finds more.

@dilipbiswal
Copy link
Contributor Author

@HyukjinKwon Sure..

Copy link
Member

@xuanyuanking xuanyuanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me with the link fix, sorry for the mistake, I'm keeping checking with similar link.

@HyukjinKwon
Copy link
Member

It's okay. the doc fix was huge and there should likely be some mistakes. I will read it closely too this weekends.

@gatorsmile
Copy link
Member

LGTM

Let us merge this PR first. If we find more, feel free to open a new follow-up PR

asfgit pushed a commit that referenced this pull request Oct 20, 2018
## What changes were proposed in this pull request?
Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-)

## How was this patch tested?
Built using jekyll and verified the links.

Closes #22772 from dilipbiswal/doc_check.

Authored-by: Dilip Biswal <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit ed9d0aa)
Signed-off-by: gatorsmile <[email protected]>
@asfgit asfgit closed this in ed9d0aa Oct 20, 2018
@dilipbiswal
Copy link
Contributor Author

Thank you @gatorsmile @HyukjinKwon @xuanyuanking

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?
Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-)

## How was this patch tested?
Built using jekyll and verified the links.

Closes apache#22772 from dilipbiswal/doc_check.

Authored-by: Dilip Biswal <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants