-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-24499][SQL][DOC][Followup] Fix some broken links #22772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #97567 has finished for PR 22772 at commit
|
|
I think we better do some proof readings before doing multiple minor followups. |
|
@HyukjinKwon Sure. If there are more changes planned in another PR, then it can take these changes in. Since this went to 2.4, i thought there may be some urgency to fix the links. |
|
Minor fixes are minor .. no need to rush to get this into 2.4. Let's take a look few more times before going ahead. We can just directly open a PR to your branch here as well if anyone finds more. |
|
@HyukjinKwon Sure.. |
xuanyuanking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for me with the link fix, sorry for the mistake, I'm keeping checking with similar link.
|
It's okay. the doc fix was huge and there should likely be some mistakes. I will read it closely too this weekends. |
|
LGTM Let us merge this PR first. If we find more, feel free to open a new follow-up PR |
## What changes were proposed in this pull request? Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-) ## How was this patch tested? Built using jekyll and verified the links. Closes #22772 from dilipbiswal/doc_check. Authored-by: Dilip Biswal <[email protected]> Signed-off-by: gatorsmile <[email protected]> (cherry picked from commit ed9d0aa) Signed-off-by: gatorsmile <[email protected]>
|
Thank you @gatorsmile @HyukjinKwon @xuanyuanking |
## What changes were proposed in this pull request? Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-) ## How was this patch tested? Built using jekyll and verified the links. Closes apache#22772 from dilipbiswal/doc_check. Authored-by: Dilip Biswal <[email protected]> Signed-off-by: gatorsmile <[email protected]>
What changes were proposed in this pull request?
Fix some broken links in the new document. I have clicked through all the links. Hopefully i haven't missed any :-)
How was this patch tested?
Built using jekyll and verified the links.