[SPARK-25754][DOC] Change CDN for MathJax #22753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #97481 has finished for PR 22753 at commit
|
felixcheung
approved these changes
Oct 17, 2018
| }; | ||
| script.src = ('https:' == document.location.protocol ? 'https://' : 'http://') + | ||
| 'cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML'; | ||
| 'cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js' + |
Member
There was a problem hiding this comment.
should we avoid hardcoding the version inline?
Member
Author
There was a problem hiding this comment.
No, according to the suggestion of the migration guide(https://www.mathjax.org/cdn-shutting-down/):
Note If you have been using https://cdn.mathjax.org/mathjax/latest/, we suggest to switch to a fixed version going forward as this represents best practices to avoid unexpected changes. That is, you will have to change the address manually to a higher number when new versions become available.
Member
Author
There was a problem hiding this comment.
I had the same concern..But I think we can use the current version unless there is important change in MathJax.
srowen
approved these changes
Oct 17, 2018
asfgit
pushed a commit
that referenced
this pull request
Oct 17, 2018
## What changes were proposed in this pull request? Currently when we open our doc site: https://spark.apache.org/docs/latest/index.html , there is one warning  This PR is to change the CDN as per the migration tips: https://www.mathjax.org/cdn-shutting-down/ This is very very trivial. But it would be good to follow the suggestion from MathJax team and remove the warning, in case one day the original CDN is no longer available. ## How was this patch tested? Manual check. Closes #22753 from gengliangwang/migrateMathJax. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 2ab4473) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.4/2.3 |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Currently when we open our doc site: https://spark.apache.org/docs/latest/index.html , there is one warning  This PR is to change the CDN as per the migration tips: https://www.mathjax.org/cdn-shutting-down/ This is very very trivial. But it would be good to follow the suggestion from MathJax team and remove the warning, in case one day the original CDN is no longer available. ## How was this patch tested? Manual check. Closes apache#22753 from gengliangwang/migrateMathJax. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when we open our doc site: https://spark.apache.org/docs/latest/index.html , there is one warning
This PR is to change the CDN as per the migration tips: https://www.mathjax.org/cdn-shutting-down/
This is very very trivial. But it would be good to follow the suggestion from MathJax team and remove the warning, in case one day the original CDN is no longer available.
How was this patch tested?
Manual check.