Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Oct 10, 2018

What changes were proposed in this pull request?

Removes all vestiges of Flume in the build, for Spark 3.
I don't think this needs Jenkins config changes.

How was this patch tested?

Existing tests.

@vanzin
Copy link
Contributor

vanzin commented Oct 10, 2018

+1, would be good to test with maven just in case.

@cloud-fan
Copy link
Contributor

sounds reasonable, also cc @tdas @zsxwing @jose-torres

@SparkQA
Copy link

SparkQA commented Oct 11, 2018

Test build #97221 has finished for PR 22692 at commit 4b39ac3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen changed the title [SPARK-25598][STREAMING][BUILD] Remove flume connector in Spark 3 [SPARK-25598][STREAMING][BUILD][test-maven] Remove flume connector in Spark 3 Oct 11, 2018
@zsxwing
Copy link
Member

zsxwing commented Oct 11, 2018

LGTM

@SparkQA
Copy link

SparkQA commented Oct 11, 2018

Test build #4370 has finished for PR 22692 at commit 4b39ac3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Oct 11, 2018

Passes with Maven and SBT, and sounds like broad support. It's clean to remove, so I'll go ahead for 3.0

@srowen
Copy link
Member Author

srowen commented Oct 11, 2018

Merged to master so I can get on with removing Kafka 0.8

@asfgit asfgit closed this in a001814 Oct 11, 2018
@srowen srowen deleted the SPARK-25598 branch October 15, 2018 16:11
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
… Spark 3

## What changes were proposed in this pull request?

Removes all vestiges of Flume in the build, for Spark 3.
I don't think this needs Jenkins config changes.

## How was this patch tested?

Existing tests.

Closes apache#22692 from srowen/SPARK-25598.

Authored-by: Sean Owen <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
sumwale pushed a commit to TIBCOSoftware/snappy-spark that referenced this pull request Feb 9, 2022
… Spark 3

Removes all vestiges of Flume in the build, for Spark 3.
I don't think this needs Jenkins config changes.

Existing tests.

Closes apache#22692 from srowen/SPARK-25598.

Authored-by: Sean Owen <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants