[SPARK-25575][WEBUI][SQL] SQL tab in the spark UI support hide tables, to make it consistent with other tabs. #22592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…how features, when the table records very much.
Contributor
Author
|
Jobs and stages page support hiding table. So to make it consistent, SQL tab also should behave the same. |
Contributor
Author
srowen
reviewed
Sep 29, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
I think it's OK. Do you need to collapse this one table though? It's the only thing on the page.
CC @ajbozarth in case he's still watching.
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Show resolved
Hide resolved
Contributor
Author
|
Thanks @srowen for reviewing.
There are 'Running', 'Completed' and 'Failed' tables in the SQL page. Similar to the Jobs page. |
Contributor
Author
|
Thank you for the review @ajbozarth . |
srowen
approved these changes
Sep 30, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
That all makes sense, I see it now. I think this is a fine change.
Contributor
Author
|
Thank you @srowen . |
Contributor
Author
|
Hi @srowen , @ajbozarth . Could you please merge the code, if there are no further comments. |
Member
|
@shahidki31 when changes aren't urgent, we usually leave them open at least a few days for comments. No need to ping unless it's been a week or something. |
|
Test build #4355 has finished for PR 22592 at commit
|
Member
|
Merged to master |
Contributor
Author
|
Thank you @srowen for merging. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…, to make it consistent with other tabs. ## What changes were proposed in this pull request? Currently, SQL tab in the WEBUI doesn't support hiding table. Other tabs in the web ui like, Jobs, stages etc supports hiding table (refer SPARK-23024 apache#20216). In this PR, added the support for hide table in the sql tab also. ## How was this patch tested? bin/spark-shell ``` sql("create table a (id int)") for(i <- 1 to 100) sql(s"insert into a values ($i)") ``` Open SQL tab in the web UI **Before fix:**  **After fix:** Consistent with the other tabs.  (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#22592 from shahidki31/SPARK-25575. Authored-by: Shahid <[email protected]> Signed-off-by: Sean Owen <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ables ## What changes were proposed in this pull request? After the PR, apache#22592, SQL tab supports collapsing table. However, after refreshing the page, it doesn't store it previous state. This was due to a typo in the argument list in the collapseTablePageLoadCommand(). ## How was this patch tested? bin/spark-shell ``` sql("create table a (id int)") for(i <- 1 to 100) sql(s"insert into a values ($i)") ```  Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#22650 from shahidki31/SPARK-25575-followUp. Authored-by: Shahid <[email protected]> Signed-off-by: Sean Owen <[email protected]>
srowen
pushed a commit
that referenced
this pull request
Nov 4, 2019
…s, to make it consistent with other tabs ### What changes were proposed in this pull request? Currently, JDBC/ODBC tab in the WEBUI doesn't support hiding table. Other tabs in the web ui like, Jobs, stages, SQL etc supports hiding table (refer #22592). In this PR, added the support for hide table in the jdbc/odbc tab also. ### Why are the changes needed? Spark ui about the contents of the form need to have hidden and show features, when the table records very much. Because sometimes you do not care about the record of the table, you just want to see the contents of the next table, but you have to scroll the scroll bar for a long time to see the contents of the next table. ### Does this PR introduce any user-facing change? No, except support of hide table ### How was this patch tested? Manually tested   Closes #26353 from shahidki31/hideTable. Authored-by: shahid <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, SQL tab in the WEBUI doesn't support hiding table. Other tabs in the web ui like, Jobs, stages etc supports hiding table (refer SPARK-23024 #20216).
In this PR, added the support for hide table in the sql tab also.
How was this patch tested?
bin/spark-shell
Open SQL tab in the web UI
Before fix:
After fix: Consistent with the other tabs.
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.