[SPARK-25564][CORE] Add output bytes metrics for each Executor #22578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vanzin
reviewed
Jan 25, 2019
| Task Time (GC Time)</span></th> | ||
| <th><span data-toggle="tooltip" | ||
| title="Bytes and records read from Hadoop or from Spark storage.">Input</span></th> | ||
| title="Bytes read from Hadoop or from Spark storage / Bytes written to Hadoop">Iuput/Output</span></th> |
Contributor
There was a problem hiding this comment.
Typo. Also in the other change.
attilapiros
reviewed
Feb 28, 2019
| "totalDuration" : 8820, | ||
| "totalGCTime" : 352, | ||
| "totalInputBytes" : 28000288, | ||
| "totalOutputBytes" : 0, |
Contributor
There was a problem hiding this comment.
It would be nice to see at least one example where the totalOutputByte is nonzero. For example you could modify an existing spark events in core/src/test/resources/spark-events as a new test test could be overkill for this.
Contributor
|
Closing due to inactivity. If you want, you can update your branch to reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LiveExecutor only statistics the total input bytes. And total output bytes for each executor also has the equal importance like input.
How was this patch tested?