[SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark behave as the same as Scala. #22552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #96604 has finished for PR 22552 at commit
|
Member
Author
|
Jenkins, retest this please. |
|
Test build #96610 has finished for PR 22552 at commit
|
Contributor
|
thanks, merging to master/2.4! |
asfgit
pushed a commit
that referenced
this pull request
Sep 27, 2018
… same as Scala. ## What changes were proposed in this pull request? In Scala, `HiveContext` sets a config `spark.sql.catalogImplementation` of the given `SparkContext` and then passes to `SparkSession.builder`. The `HiveContext` in PySpark should behave as the same as Scala. ## How was this patch tested? Existing tests. Closes #22552 from ueshin/issues/SPARK-25540/hive_context. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit c3c45cb) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
hm, why did we merge this into 2.4 btw? |
Contributor
daspalrahul
pushed a commit
to daspalrahul/spark
that referenced
this pull request
Sep 29, 2018
… same as Scala. ## What changes were proposed in this pull request? In Scala, `HiveContext` sets a config `spark.sql.catalogImplementation` of the given `SparkContext` and then passes to `SparkSession.builder`. The `HiveContext` in PySpark should behave as the same as Scala. ## How was this patch tested? Existing tests. Closes apache#22552 from ueshin/issues/SPARK-25540/hive_context. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Scala,
HiveContextsets a configspark.sql.catalogImplementationof the givenSparkContextand then passes toSparkSession.builder.The
HiveContextin PySpark should behave as the same as Scala.How was this patch tested?
Existing tests.