-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25306][SQL][FOLLOWUP] Change test to ignore in FilterPushdownBenchmark
#22336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ownBenchmark
|
Sorry, @cloud-fan . I forgot to turn off the benchmark test in the previous PR. We need to disable it like the other micro benchmark test. |
|
I'm surprised this benchmark is written as a test suite. I'm ok with this PR, but later we should refactor this benchmark to use |
|
LGTM |
|
Yep. I see. I'll refactor it later, @cloud-fan . Also, thanks, @kiszk and @HyukjinKwon |
|
Test build #95693 has finished for PR 22336 at commit
|
|
retest this please |
|
Test build #95699 has finished for PR 22336 at commit
|
|
retest this please |
|
Test build #95710 has finished for PR 22336 at commit
|
|
retest this please |
|
Test build #95722 has finished for PR 22336 at commit
|
|
Finally, it's passed. Shall I merge this, @cloud-fan and @HyukjinKwon ? :) |
|
Sorry,,, I just merged it to master |
|
Wow, Great. Thanks, @gatorsmile ! |
What changes were proposed in this pull request?
This is a follow-up of #22313 and aim to ignore the micro benchmark test which takes over 2 minutes in Jenkins.
How was this patch tested?
The test case should be ignored in Jenkins.