Skip to content

Conversation

@koertkuipers
Copy link
Contributor

What changes were proposed in this pull request?

  1. Set nullValue to quoted empty string respecting quote value
  2. Fall back to old behavior of unquoted null if quote is not set

How was this patch tested?

Two new tests that will fail without these fixes

Please review http://spark.apache.org/contributing.html before opening a pull request.

@SparkQA
Copy link

SparkQA commented Sep 1, 2018

Test build #95581 has finished for PR 22312 at commit ad3a11d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 2, 2018

Test build #95582 has finished for PR 22312 at commit 5772404.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

#22234 was already open. Wouldn't it be able to workaround if it's configurable?

@wangyum wangyum mentioned this pull request Nov 3, 2018
@asfgit asfgit closed this in 463a676 Nov 4, 2018
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#22859
Closes apache#22849
Closes apache#22591
Closes apache#22322
Closes apache#22312
Closes apache#19590

Closes apache#22934 from wangyum/CloseStalePRs.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants