Skip to content

Conversation

@arunmahadevan
Copy link
Contributor

  • Mark custom metrics related APIs as unstable
  • Move CustomMetrics (and a few other streaming interfaces in parent package) to streaming package

Ideally could move v2/reader/streaming and v2/writer/streaming under streaming/reader and streaming/writer but that can be a follow up PR if required.

How was this patch tested?

Existing unit tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

- Mark custom metrics related APIs as unstable
- Move streaming related interfaces to streaming package
@jerryshao
Copy link
Contributor

Seems there's another similar PR #22296 .

@HyukjinKwon
Copy link
Member

Thanks, @jerryshao for pointing this out. I will close mine after we see what we want.

@SparkQA
Copy link

SparkQA commented Aug 31, 2018

Test build #95521 has finished for PR 22299 at commit 49a94c6.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Aug 31, 2018

Test build #95530 has finished for PR 22299 at commit 49a94c6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants