[SPARK-23698][Python] Avoid 'undefined name' by defining __version__ #22214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent linters from raising __undefined name '\_\_version\_\_'__ by initializing the variable before setting it via a call to __exec()__. This is the last remaining issue related to the work done in apache#20838
Contributor
|
Jenkins, ok to test. |
Member
|
It should have been better fixed together rather then 3 PRs to fix the same instances. |
Member
|
ok to test |
HyukjinKwon
reviewed
Aug 25, 2018
| file=sys.stderr) | ||
| sys.exit(-1) | ||
|
|
||
| __version__ = "Unknown" # Prevent linters from raising 'undefined name' |
Member
There was a problem hiding this comment.
Shall we simply noqa for VERSION = __version__? looks weird we have a version defined as Unknown to fix lint errors.
|
Test build #95243 has finished for PR 22214 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prevent linters from raising undefined name '__version__' by initializing the variable before setting it via a call to exec(). This is the last remaining issue related to the work done in #20838
How was this patch tested?
Please review http://spark.apache.org/contributing.html before opening a pull request.