[SPARK-25098][SQL]‘Cast’ will return NULL when input string starts/en… #22089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds with special character(s)
|
Can one of the admins verify this patch? |
mgaido91
reviewed
Aug 13, 2018
| case StringType => | ||
| buildCast[UTF8String](_, utfs => DateTimeUtils.stringToTimestamp(utfs, timeZone).orNull) | ||
| buildCast[UTF8String](_, utfs => DateTimeUtils.stringToTimestamp( | ||
| UTF8String.fromString(utfs.toString.trim), timeZone).orNull) |
Member
|
ping @bingbai0912 |
gatorsmile
reviewed
Nov 4, 2018
| c.set(Calendar.MILLISECOND, 0) | ||
| checkEvaluation(Cast(Literal("2015-03-18"), DateType), new Date(c.getTimeInMillis)) | ||
| checkEvaluation(Cast(Literal("2015-03-18 "), DateType), new Date(c.getTimeInMillis)) | ||
| checkEvaluation(Cast(Literal(" 2015-03-18"), DateType), new Date(c.getTimeInMillis)) |
Member
There was a problem hiding this comment.
SELECT CAST(' 22-OCT-1997' AS TIMESTAMP) FROM dual;
Oracle also trims the leading space.
Member
|
@wangyum Could you please take it over? |
Member
|
Sure, @gatorsmile . |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ringToDate ## What changes were proposed in this pull request? **Hive** and **Oracle** trim the string when cast `stringToTimestamp` and `stringToDate`. this PR support this feature:   ## How was this patch tested? unit tests Closes apache#22089 Closes apache#22943 from wangyum/SPARK-25098. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
UDF ‘Cast’ will return NULL when input string starts/ends with special character, but hive doesn't.
For examle, we get hour from a string ends with a blank :
hive：
spark-sql:
All of the following UDFs will be affected:
How was this patch tested?
Add test cases