[SPARK-25092] Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules#22080
Closed
dilipbiswal wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-25092] Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules#22080dilipbiswal wants to merge 1 commit intoapache:masterfrom
dilipbiswal wants to merge 1 commit intoapache:masterfrom
Conversation
…t of nonExcludableRules
dilipbiswal
commented
Aug 11, 2018
| OptimizeSubqueries) :: | ||
| Batch("Replace Operators", fixedPoint, | ||
| RewriteExcepAll, | ||
| RewriteExceptAll, |
|
Test build #94625 has finished for PR 22080 at commit
|
gatorsmile
reviewed
Aug 12, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM. Thanks! Merged to master.
Contributor
Author
|
Thanks a lot @gatorsmile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules as the rewrites are essential for the functioning of EXCEPT ALL and INTERSECT ALL feature.
How was this patch tested?
Added test in OptimizerRuleExclusionSuite.