[SPARK-25090][ML] Enforce implicit type coercion in ParamGridBuilder#22076
Closed
mgaido91 wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-25090][ML] Enforce implicit type coercion in ParamGridBuilder#22076mgaido91 wants to merge 2 commits intoapache:masterfrom
mgaido91 wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #94609 has finished for PR 22076 at commit
|
Contributor
Author
HyukjinKwon
approved these changes
Aug 11, 2018
HyukjinKwon
reviewed
Aug 12, 2018
python/pyspark/ml/tests.py
Outdated
| paramGrid = ParamGridBuilder().addGrid(lr.regParam, [0.5, 1]).build() | ||
| for param in paramGrid: | ||
| for v in param.values(): | ||
| assert(type(v) is float) |
|
Test build #94647 has finished for PR 22076 at commit
|
Member
|
LGTM |
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the grid of the parameters is created in
ParamGridBuilder, the implicit type coercion is not enforced. So using an integer in the list of parameters to set for a parameter accepting a double can cause a class cast exception.The PR proposes to enforce the type coercion when building the parameters.
How was this patch tested?
added UT