[MINOR][DOC] Fix Java example code in Column's comments#22069
Closed
da-liii wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][DOC] Fix Java example code in Column's comments#22069da-liii wants to merge 1 commit intoapache:masterfrom
da-liii wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
ok to test |
HyukjinKwon
approved these changes
Aug 10, 2018
srowen
approved these changes
Aug 10, 2018
|
Test build #94555 has finished for PR 22069 at commit
|
Member
|
Do we need to update the following similar examples, too? Column.scala functions.scala |
|
Test build #4239 has finished for PR 22069 at commit
|
Member
|
Yea if there are more instances found, we better fix them together |
Member
|
retest this please |
|
Test build #94595 has finished for PR 22069 at commit
|
Member
|
retest this please |
|
Test build #94613 has finished for PR 22069 at commit
|
Member
|
retest this please |
|
Test build #94620 has finished for PR 22069 at commit
|
Member
Member
|
I'm going to merge this, as the additional example quoted above should actually work, assuming one imported the 'col' function. In Java, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix scaladoc in Column
How was this patch tested?
None