Skip to content

[SPARK-25079][PYTHON] preparing for python 3.5 bump #22061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaneknapp wants to merge 1 commit into from
Closed

[SPARK-25079][PYTHON] preparing for python 3.5 bump #22061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def run_individual_python_test(target_dir, test_name, pyspark_python):


def get_default_python_executables():
python_execs = [x for x in ["python2.7", "python3.4", "pypy"] if which(x)]
python_execs = [x for x in ["python2.7", "python3.4", "python3.5", "pypy"] if which(x)]
Copy link
Contributor Author

@shaneknapp shaneknapp Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will push another commit at some point in the future to remove the reference to python3.4.

Copy link
Member

@BryanCutler BryanCutler Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why not replace python3.4 now? From the steps in jira, there will be a symlink for 3.4 -> 3.5 so it would be running the same tests twice right?

if "python2.7" not in python_execs:
LOGGER.warning("Not testing against `python2.7` because it could not be found; falling"
" back to `python` instead")
Expand Down