Skip to content

[SPARK-25033] Bump Apache commons.{httpclient, httpcore}#22007

Closed
Fokko wants to merge 3 commits intoapache:masterfrom
Fokko:SPARK-25033
Closed

[SPARK-25033] Bump Apache commons.{httpclient, httpcore}#22007
Fokko wants to merge 3 commits intoapache:masterfrom
Fokko:SPARK-25033

Conversation

@Fokko
Copy link
Copy Markdown
Contributor

@Fokko Fokko commented Aug 6, 2018

What changes were proposed in this pull request?

Bump the versions of Apache commons.{httpclient, httpcore} to make it congruent with Stocator.

Changelog httpclient: https://archive.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES-4.5.x.txt
Changelog httpcore: https://archive.apache.org/dist/httpcomponents/httpcore/RELEASE_NOTES.txt

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

@kiszk
Copy link
Copy Markdown
Member

kiszk commented Aug 8, 2018

@Fokko Do we need to update files under dev/deps?

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Aug 8, 2018

Good point @kiszk. I've just updated the files.

@kiszk
Copy link
Copy Markdown
Member

kiszk commented Aug 8, 2018

This change looks non-risky to me.
cc @swoen @HyukjinKwon

@HyukjinKwon
Copy link
Copy Markdown
Member

ok to test

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 10, 2018

Test build #94553 has finished for PR 22007 at commit 618de1e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 10, 2018

Test build #94563 has finished for PR 22007 at commit 316b9ad.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Aug 10, 2018

I don't really understand the error, can a Spark expert elaborate what's going on here?

@HyukjinKwon
Copy link
Copy Markdown
Member

retest this please

@HyukjinKwon
Copy link
Copy Markdown
Member

If you find this is unrelated, you could trigger another test here

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 10, 2018

Test build #94580 has finished for PR 22007 at commit 316b9ad.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Copy Markdown
Member

kiszk commented Aug 11, 2018

retest this please

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 11, 2018

Test build #94615 has finished for PR 22007 at commit 316b9ad.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Copy Markdown
Member

kiszk commented Aug 11, 2018

LGTM

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Aug 12, 2018

Nice! What was the issue with Travis? Feels like some caching to me :)

@HyukjinKwon
Copy link
Copy Markdown
Member

HyukjinKwon commented Aug 13, 2018

We don't currently run Travis in Spark.

@HyukjinKwon
Copy link
Copy Markdown
Member

Merged to master.

@asfgit asfgit closed this in 5d6abad Aug 13, 2018
@gatorsmile
Copy link
Copy Markdown
Member

The bump is fine but this is not for making it congruent with Stocator, which is just an external connector.

@Fokko Fokko deleted the SPARK-25033 branch October 25, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants