Skip to content

Conversation

@jiangxb1987
Copy link
Contributor

What changes were proposed in this pull request?

According to #21758 (comment) , current declaration of BarrierTaskContext didn't extend methods from TaskContext. Since TaskContext is an abstract class and we don't want to change it to a trait, we have to define class BarrierTaskContext directly.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #94018 has finished for PR 21972 at commit e5987cf.

  • This patch fails to generate documentation.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 2, 2018

LGTM pending Jenkins.

@mengxr
Copy link
Contributor

mengxr commented Aug 2, 2018

test this please

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #94022 has finished for PR 21972 at commit f3ea13d.

  • This patch fails from timeout after a configured wait of `300m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 2, 2018

[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target/java/org/apache/spark/rdd/RDDBarrier.java:9: error: reference not found
[error]    * Maps partitions together with a provided {@link BarrierTaskContext}.
[error]  

@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #94029 has finished for PR 21972 at commit f3ea13d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 3, 2018

LGTM. Merged into master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants