Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Aug 1, 2018

What changes were proposed in this pull request?

In response to a recent question, this reiterates that network access to a Spark cluster should be disabled by default, and that access to its hosts and services from outside a private network should be added back explicitly.

Also, some minor touch-ups while I was at it.

How was this patch tested?

N/A

@holdensmagicalunicorn
Copy link

@srowen, thanks! I am a bot who has found some folks who might be able to help with the review:@pwendell, @vanzin and @mcavdar

@SparkQA
Copy link

SparkQA commented Aug 1, 2018

Test build #93892 has finished for PR 21947 at commit b5b14d0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 1, 2018

Test build #93902 has finished for PR 21947 at commit a59672b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

docs/_config.yml Outdated
highlighter: pygments
markdown: kramdown
gems:
plugins:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I am worried though we replace this and some Jenkins builds don't work because the jekyll version is too old (looks it requires 3.5+?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK I'll back that out. Keeping jekyll up to date might be needed eventually but not worth it here.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one worry

@HyukjinKwon
Copy link
Member

Let me just push this in. The last change shouldn't really affect anything ..

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in c9914cf Aug 2, 2018
@SparkQA
Copy link

SparkQA commented Aug 2, 2018

Test build #93929 has finished for PR 21947 at commit e6f5a3f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen deleted the SecurityNote branch August 2, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants