Skip to content

[SQL][HIVE] Correct an assert message in function makeRDDForTable #21836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SongYadong wants to merge 4 commits into from
Closed

[SQL][HIVE] Correct an assert message in function makeRDDForTable #21836

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a0f729
correct an assert info in function makeRDDForTable
SongYadong Jul 22, 2018
56f87f0
Solve Scala style checks failure.
SongYadong Jul 23, 2018
085ffdb
Fix scala style checks failure in another way.
SongYadong Jul 23, 2018
7dc889b
Delete whitespace at end of line
SongYadong Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ class HadoopTableReader(
filterOpt: Option[PathFilter]): RDD[InternalRow] = {

assert(!hiveTable.isPartitioned, """makeRDDForTable() cannot be called on a partitioned table,
since input formats may differ across partitions. Use makeRDDForTablePartitions() instead.""")
since input formats may differ across partitions. Use makeRDDForPartitionedTable()
Copy link
Member

@HyukjinKwon HyukjinKwon Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's gonna keep the white spaces as is. Mind if I ask change this as below?

assert(
  !hiveTable.isPartitioned,
  "makeRDDForTable() cannot be called on a partitioned table, since input formats may differ " +
    "across partitions. Use makeRDDForTablePartitions() instead."

Copy link
Contributor Author

@SongYadong SongYadong Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Good. I will modify it, thanks.

instead.""")

// Create local references to member variables, so that the entire `this` object won't be
// serialized in the closure below.
Expand Down